better os-release handling, and sunos ascii

pfetch

@@ -154,19 +154,23 @@ get_os() {
             if command -v lsb_release; then
                 distro=$(lsb_release -sd)
 
-                # lsb_release sometimes adds quotes around the output,
-                # this simply remove quotes from the start/end if they
-                # exist.
-                distro=${distro##\"}
-                distro=${distro%%\"}
-
             else
-                # Disable warning about shellcheck not being able
+                # This used to be a simple '. /etc/os-release' but I believe
-                # to read '/etc/os-release'. This is fine.
+                # this is insecure as we blindly execute whatever is in the
-                # shellcheck source=/dev/null
+                # file. This parser instead simply handles 'key=val', treating
-                . /etc/os-release && distro=$PRETTY_NAME
+                # the file contents as plain-text.
+                while IFS='=' read -r key val; do
+                    case $key in
+                        PRETTY_NAME) distro=$val ;;
+                    esac
+                done < /etc/os-release
             fi
 
+            # 'os-release' and 'lsb_release' sometimes add quotes
+            # around the distribution name, strip them.
+            distro=${distro##[\"\']}
+            distro=${distro%%[\"\']}
+
             # Special cases for (independent) distributions which
             # don't follow any os-release/lsb standards whatsoever.
             command -v crux && distro=$(crux)
@@ -1029,6 +1033,16 @@ get_ascii() {
 			EOF
         ;;
 
+        [Ss]un[Oo][Ss])
+            read_ascii 3 <<-EOF
+				${c3}       .   .;   .
+				   .   :;  ::  ;:   .
+				   .;. ..      .. .;.
+				..  ..             ..  ..
+				 .;,                 ,;.
+			EOF
+        ;;
+
         [Uu]buntu*)
             read_ascii 3 <<-EOF
 				${c3}         _