CMakeLists.txt: suppress some warnings also for gcc, not only clang

also, check for AppleClang, not only Clang.
This commit is contained in:
Daniel Gibson 2016-04-21 20:30:53 +02:00
parent c74fa69bf6
commit 1f23f37b36

View File

@ -112,9 +112,20 @@ if(CMAKE_COMPILER_IS_GNUCC OR CMAKE_C_COMPILER_ID STREQUAL "Clang")
# TODO fix these warnings # TODO fix these warnings
add_compile_options(-Wno-sign-compare) add_compile_options(-Wno-sign-compare)
add_compile_options(-Wno-switch) add_compile_options(-Wno-switch)
add_compile_options(-Wno-format-security) add_compile_options(-Wno-unknown-pragmas)
add_definitions(-Wno-logical-op-parentheses) add_compile_options(-Wno-unused-variable)
MESSAGE(WARNING, "re-enable -Wlogical-op-parentheses some day!") add_compile_options(-Wno-unused-value)
add_compile_options(-Wno-reorder)
add_compile_options(-Wno-unused-but-set-variable)
add_compile_options(-Wno-parentheses)
MESSAGE(WARNING, "re-enable some of the warnings some day!")
if(CMAKE_CXX_COMPILER_ID MATCHES "Clang" OR CMAKE_CXX_COMPILER_ID MATCHES "AppleClang")
# !!! FIXME: turn a bunch of these off, this is just for now. I hope. --ryan.
add_compile_options(-Wno-tautological-undefined-compare)
add_compile_options(-Wno-c++11-compat-deprecated-writable-strings)
add_compile_options(-Wno-logical-op-parentheses) # FIXME: this too should be re-enabled
endif()
if(MACOSX) if(MACOSX)
add_definitions(-DPLATFORM_UNIX=1) add_definitions(-DPLATFORM_UNIX=1)
@ -151,16 +162,6 @@ if(CMAKE_COMPILER_IS_GNUCC OR CMAKE_C_COMPILER_ID STREQUAL "Clang")
add_compile_options(-Wno-invalid-offsetof) add_compile_options(-Wno-invalid-offsetof)
endif() endif()
if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
# !!! FIXME: turn a bunch of these off, this is just for now. I hope. --ryan.
add_compile_options(-Wno-unused-value)
add_compile_options(-Wno-switch)
add_compile_options(-Wno-tautological-undefined-compare)
add_compile_options(-Wno-c++11-compat-deprecated-writable-strings)
add_definitions(-Wno-logical-op-parentheses)
MESSAGE(WARNING "reenable -Wlogical-op-parentheses some day!")
endif()
elseif(MSVC) # RAKE! I don't know if this will build with MSVC elseif(MSVC) # RAKE! I don't know if this will build with MSVC
add_compile_options(/W4) add_compile_options(/W4)
add_compile_options(/wd4100) # unreferenced formal parameter add_compile_options(/wd4100) # unreferenced formal parameter